Do some pedantic spring cleaning

- Use const in more places where it makes sense - not absolutely
  everywhere because it can get a bit annoying

- Make all the instruction search loops a bit more readable by casting
  the function pointer into a temporary variable to loop over

- Add a few more doc comments and fix a typo or two

- Make that RTTI thing flexibly-sized, finally

- Don't include gamedata.h in vcall.h for no reason; consequently
  include gamedata.h in a bunch of places where it was implictly pulled
  in before

- Fix dbg_toghidra() and ent_getedict() having mismatched return types
  between their headers and respective source files

- Remove that one broken, hacky, secret Portal non-feature that probably
  nobody even ended up using; it can be implemented properly later if
  required

1 files changed, 3 insertions, 2 deletions

diff --git a/src/bind.c b/src/bind.c
index 41fd437..97864c8 100644
--- a/src/bind.c
+++ b/src/bind.c
@@ -1,5 +1,5 @@
 /*
- * Copyright © 2022 Michael Smith <mikesmiffy128@gmail.com>
+ * Copyright © 2023 Michael Smith <mikesmiffy128@gmail.com>
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -37,7 +37,8 @@ const char *bind_get(int keycode) { return keyinfo[keycode].binding; }
 
 static bool find_keyinfo(con_cmdcb klbc_cb) {
 #ifdef _WIN32
-	for (uchar *p = (uchar *)klbc_cb; p - (uchar *)klbc_cb < 32;) {
+	const uchar *insns = (const uchar *)klbc_cb;
+	for (const uchar *p = insns; p - insns < 32;) {
 		// key_listboundkeys command, in its loop through each possible index,
 		// does a mov from that index into a register, something like:
 		// mov <reg>, dword ptr [<reg> * 8 + s_pKeyInfo]