From cba9387c361c3d33dcf1b21ff0e5beb4b0a81ade Mon Sep 17 00:00:00 2001 From: Michael Smith Date: Tue, 16 May 2023 22:12:57 +0100 Subject: Do some pedantic spring cleaning - Use const in more places where it makes sense - not absolutely everywhere because it can get a bit annoying - Make all the instruction search loops a bit more readable by casting the function pointer into a temporary variable to loop over - Add a few more doc comments and fix a typo or two - Make that RTTI thing flexibly-sized, finally - Don't include gamedata.h in vcall.h for no reason; consequently include gamedata.h in a bunch of places where it was implictly pulled in before - Fix dbg_toghidra() and ent_getedict() having mismatched return types between their headers and respective source files - Remove that one broken, hacky, secret Portal non-feature that probably nobody even ended up using; it can be implemented properly later if required --- src/hook.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/hook.c') diff --git a/src/hook.c b/src/hook.c index eacac4a..ff7ac96 100644 --- a/src/hook.c +++ b/src/hook.c @@ -1,5 +1,5 @@ /* - * Copyright © 2022 Michael Smith + * Copyright © 2023 Michael Smith * Copyright © 2022 Willian Henrique * * Permission to use, copy, modify, and/or distribute this software for any @@ -102,7 +102,7 @@ nosp: con_warn("hook_inline: out of trampoline space\n"); } void unhook_inline(void *orig) { - uchar *p = (uchar *)orig; + uchar *p = orig; int len = p[-1]; int off = mem_load32(p + len + 1); uchar *q = p + off + 5; -- cgit v1.2.3